Page MenuHomeFreeBSD

ixgbe: Avoid sbuf_trim in sysctl handler
ClosedPublic

Authored by kbowling on Aug 22 2021, 5:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 9:57 AM
Unknown Object (File)
Mon, Nov 11, 7:49 AM
Unknown Object (File)
Mon, Nov 11, 7:05 AM
Unknown Object (File)
Mon, Nov 11, 5:08 AM
Unknown Object (File)
Mon, Nov 11, 4:59 AM
Unknown Object (File)
Mon, Nov 11, 4:32 AM
Unknown Object (File)
Mon, Nov 11, 3:11 AM
Unknown Object (File)
Mon, Nov 11, 2:02 AM
Subscribers

Details

Summary

This was an error, we cannot use sbuf_trim(9) in the ixgbe_get_phy_firmware_version function because it also gets called in the context of sbuf_new_for_sysctl(9). sbuf(9) explains the interaction with drain functions as used by sbuf_new_for_sysctl(9).

MFC after: 1 day
Fixes: 7660e4ea5cb7

Test Plan

Tested on X552.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Suggested approach which I think might be simpler, but the only mandatory thing is the final space that got left in.

sys/dev/ixgbe/if_ix.c
4698

I'd add a const char *space = ""; here

4706–4708

Then add space =" "; here with {}

4711

and use space here instead of this express....

4712

with the same space = " "; here.

4717

and replace this with space.

4723

I think you missed one of the trailing white spaces here.. It would have been trimmed before.

This revision is now accepted and ready to land.Aug 23 2021, 5:17 PM