Paths

Table of Contentst

Differential D31550

iflib: emulate counters in netmap mode
ClosedPublic
Actions

Authored by franco_opnsense.org on Aug 16 2021, 7:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 12:03 PM

	Unknown Object (File)
	Fri, Nov 8, 11:31 AM

	Unknown Object (File)
	Fri, Nov 8, 9:47 AM

	Unknown Object (File)
	Thu, Oct 24, 3:00 AM

	Unknown Object (File)
	Oct 1 2024, 4:19 AM

	Unknown Object (File)
	Sep 30 2024, 7:37 PM

	Unknown Object (File)
	Sep 30 2024, 9:15 AM

	Unknown Object (File)
	Sep 23 2024, 6:03 AM

View All 78 Files

Subscribers

stephan.dewt_yahoo.co.uk

Contributor Reviews (src)

Details

Reviewers

shurd
vmaffione
erj
gallatin

Group Reviewers

Commits

rG477308acc5f0: iflib: emulate counters in netmap mode
rG8cb9af94fffc: iflib: emulate counters in netmap mode
rG66fa12d8fb61: iflib: emulate counters in netmap mode

Summary

When iflib devices are in netmap mode the driver
counters are no longer updated making it look from
userspace tools that traffic has stopped.

Submitted by: Stephan de Wit
PR: 252850

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

franco_opnsense.org created this revision.Aug 16 2021, 7:53 AM

Herald added a reviewer: shurd. · View Herald TranscriptAug 16 2021, 7:53 AM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: Contributor Reviews (src), melifaro, ae, imp. · View Herald Transcript

franco_opnsense.org requested review of this revision.Aug 16 2021, 7:53 AM

Harbormaster completed remote builds in B41053: Diff 93734.Aug 16 2021, 7:53 AM

franco_opnsense.org added a reviewer: vmaffione.Aug 16 2021, 7:59 AM

franco_opnsense.org added a subscriber: stephan.dewt_yahoo.co.uk.

This seems fine to me.

This revision is now accepted and ready to land.Aug 16 2021, 3:55 PM

Good idea, thanks! I added just a little comment.

sys/net/iflib.c
1082	I think this should be `pkt_len`, which is the cumulative size of a multi-descriptor packet, whereas `len` is the size of the last descriptor only.

This revision now requires changes to proceed.Aug 17 2021, 11:22 AM

fixed partial length on tx

Harbormaster completed remote builds in B41097: Diff 93819.Aug 17 2021, 11:42 AM

franco_opnsense.org marked an inline comment as done.Aug 17 2021, 11:44 AM

franco_opnsense.org added inline comments.

sys/net/iflib.c
1082	Nice catch, thanks! I changed it to pi.ipi_len where pkg_len is stored to avoid the dependency on an internal variable.

LGTM, thanks

This revision is now accepted and ready to land.Aug 17 2021, 11:49 AM

gallatin accepted this revision.Aug 17 2021, 2:51 PM

Appreciate the reviews :) Unfortunately I'm not a committer so is someone willing to help out? Thanks in advance.

I'll close the relevant bug report as well: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252850

franco_opnsense.org edited the summary of this revision. (Show Details)Aug 18 2021, 7:16 AM

Closed by commit rG66fa12d8fb61: iflib: emulate counters in netmap mode (authored by stephan.dewt_yahoo.co.uk, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyAug 18 2021, 7:20 AM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG66fa12d8fb61: iflib: emulate counters in netmap mode.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG8cb9af94fffc: iflib: emulate counters in netmap mode.Aug 25 2021, 11:52 PM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG477308acc5f0: iflib: emulate counters in netmap mode.Aug 26 2021, 12:04 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

18 lines

Diff 93861

sys/net/iflib.c

Loading...