Page MenuHomeFreeBSD

routing: Fix crashes with dpdk_lpm algo.
ClosedPublic

Authored by melifaro on Aug 15 2021, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 12:03 PM
Unknown Object (File)
Thu, Nov 7, 1:36 AM
Unknown Object (File)
Tue, Nov 5, 8:21 AM
Unknown Object (File)
Mon, Nov 4, 1:16 AM
Unknown Object (File)
Wed, Oct 16, 12:31 AM
Unknown Object (File)
Tue, Oct 15, 1:11 AM
Unknown Object (File)
Sun, Oct 13, 10:44 PM
Unknown Object (File)
Sun, Oct 13, 6:51 AM
Subscribers

Details

Summary

When a prefix gets deleted from the RIB, dpdk_lpm algo needs to know
the nexthop of the "parent" prefix to update its internal state.
The glue code, which utilises RIB as a backing route store, used
fib4_lookup_rt() after the prefix deletion. This approach didn't
work for "nested prefixes": if 10.0.0.0/24, 10.0.0.0/23 and 10.0.0.0/22
exists in RIB, deleting 10.0.0.0/23 resulted in 10.0.0.0/24 being
returned. This, in turn, resulted in failure to update the entire
/23 with a next nexhop, leading to eventual crashes.

Fix this by creating per-family rt_get_inet[6]_parent() helpers
and using them in the dpdk_lpm code.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable