linux(4): Add AT_NO_AUTOMOUNT to statx.
ClosedPublic
Actions

Authored by dchagin on Aug 12 2021, 4:36 PM.

Details

Reviewers

trasz

Group Reviewers

Linux Emulation

Commits

rG221d908864dd: linux(4): Add AT_NO_AUTOMOUNT to statx.
rGff39d74aa99a: linux(4): Add AT_NO_AUTOMOUNT to statx.

Summary

Specific to Linux AT_NO_AUTOMOUNT flag tells the kernel to not automount the
terminal component of pathname if it is a directory that is an automount point.
As it is the default for FreeBSD silencly ignore this flag.

glibc-2.34 uses this flag in the stat64 system calls which is used by i386.

Test Plan

glibc tests

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Aug 12 2021, 4:36 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 12 2021, 4:36 PM

dchagin requested review of this revision.Aug 12 2021, 4:36 PM

Harbormaster completed remote builds in B41020: Diff 93622.Aug 12 2021, 4:36 PM

dchagin edited the test plan for this revision. (Show Details)Aug 12 2021, 4:40 PM

dchagin added a reviewer: Linux Emulation.

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

Maybe worth a comment in the code (the explanation in this review) about LINUX_AT_NO_AUTOMOUNT being the default on FreeBSD? Else it might be confusing that we claim it is a supported flag but do not do anything to handle it.