Differential D31322

LinuxKPI: add fsleep()
ClosedPublic
Actions

Authored by bz on Jul 27 2021, 3:26 PM.

Details

Reviewers

• hselasky

Group Reviewers

linuxkpi

Commits

rGcc2723370b48: LinuxKPI: add fsleep()

Summary

Add fsleep() function now required by rtw88. This seems to be
making a decision depending on time to sleep on how to sleep.
Given our compat framework already is lenient on how long to sleep,
this is a cut down version.

MFC after: 10 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Jul 27 2021, 3:26 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptJul 27 2021, 3:26 PM

bz requested review of this revision.Jul 27 2021, 3:26 PM

Harbormaster completed remote builds in B40694: Diff 92800.Jul 27 2021, 3:26 PM

emaste added inline comments.Jul 27 2021, 3:52 PM

sys/compat/linuxkpi/common/include/linux/delay.h
83	IMO the scaling by hz deserves a comment

• hselasky added a subscriber: • hselasky.Jul 27 2021, 4:26 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/delay.h
84	Do you have to use DELAY() ? Else use pause_sbt!

bz marked 2 inline comments as done.Jul 27 2021, 6:26 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/delay.h
83	will do if it'll survive the update triggered by @hselasky (see below).
84	I think the idea is to have a busy loop if the timeouts are small enough; now you asking make me notice that the code from this file had changed under my branch. I'll update and make this more fine grained after all.

Change the logic using the previously missed updated implementations
in this file. Still keep it cut down (just the other way round).
This automatically addresses the comment from @hselasky and @emaste.

Harbormaster completed remote builds in B40714: Diff 92854.Jul 28 2021, 12:28 PM

• hselasky accepted this revision.Jul 28 2021, 1:12 PM

This revision is now accepted and ready to land.Jul 28 2021, 1:12 PM

Closed by commit rGcc2723370b48: LinuxKPI: add fsleep() (authored by bz). · Explain WhyJul 28 2021, 1:38 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGcc2723370b48: LinuxKPI: add fsleep().