devctl: don't publish the mount options
ClosedPublic
Actions

Authored by imp on Jul 23 2021, 3:46 PM.

Details

Reviewers

markj

Commits

rG351acbedde16: devctl: don't publish the mount options
rG6475667f7b72: devctl: don't publish the mount options

Summary

Mount options aren't solely ASCII strings. In addition, experience to
date suggests that the mount options are much less useful than was
originally supposed and the mount flags suffice to make decisions. Drop
the reporting of options for the mount/remount/unmount events.

Found by: KASAN / markj
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 23 2021, 3:46 PM

imp created this revision.

Harbormaster completed remote builds in B40641: Diff 92681.Jul 23 2021, 3:46 PM

imp added a reviewer: markj.Jul 23 2021, 3:46 PM

markj added inline comments.Jul 23 2021, 3:52 PM

sys/kern/vfs_mount.c
2563	Maybe use the entries from `global_opts[]`?

imp retitled this revision from devctl: only publish the values of known options to devctl: don't publish the mount options.Jul 23 2021, 8:05 PM

imp edited the summary of this revision. (Show Details)

update, per IRC conversation, to simply not publish the option list.

Harbormaster completed remote builds in B40651: Diff 92692.Jul 23 2021, 8:05 PM

I think this is ok. An interested consumer could fetch some of the options with statfs(). There is a window between the devctl event and a statfs() call where the mount options could change, but in that case you'd get another event.