Page MenuHomeFreeBSD
Differential D31194

tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.
ClosedPublic
Actions

Authored by rrs on Jul 15 2021, 3:09 PM.
Tags
None
Referenced Files
F115224251: D31194.id.diff
Mon, Apr 21, 2:30 PM
F115214219: D31194.id92229.diff
Mon, Apr 21, 12:15 PM
F115213983: D31194.id92229.diff
Mon, Apr 21, 12:13 PM
F115210351: D31194.diff
Mon, Apr 21, 11:27 AM
F115209054: D31194.id92287.diff
Mon, Apr 21, 11:09 AM
F115206810: D31194.id.diff
Mon, Apr 21, 10:38 AM
F115203975: D31194.diff
Mon, Apr 21, 10:03 AM
Unknown Object (File)
Mon, Apr 21, 12:03 AM
View All 68 Files
Subscribers
melifaro

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the…
Summary

There is a bug in the error path where rack_bbr_common does a m_pullup() and the pullup fails.
There is a stray mfree(m) after m is set to NULL. This is not a good idea :-)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
2 lines

Diff 92287

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...