Paths

Table of Contentst

Differential D31040

Add missing dep patterns for .pieo
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 9:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 21, 10:48 AM

	Unknown Object (File)
	Sep 19 2024, 9:13 PM

	Unknown Object (File)
	Sep 17 2024, 6:52 AM

	Unknown Object (File)
	Sep 13 2024, 4:19 AM

	Unknown Object (File)
	Sep 13 2024, 4:19 AM

	Unknown Object (File)
	Sep 13 2024, 4:19 AM

	Unknown Object (File)
	Sep 13 2024, 2:46 AM

	Unknown Object (File)
	Sep 8 2024, 5:33 PM

View All 77 Files

Subscribers

Details

Reviewers

emaste
bdrewery
sjg
imp

Commits

rGcbbdacf4dc8f: Add missing dep patterns for .pieo
rG2d78130185b5: Add missing dep patterns for .pieo

Summary

While adding sanitizer support, I noticed that all other extensions were
handled but .pieo was missing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jul 5 2021, 9:48 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 9:48 AM

arichardson requested review of this revision.Jul 5 2021, 9:48 AM

Harbormaster completed remote builds in B40286: Diff 91762.Jul 5 2021, 9:48 AM

add missing variable

Harbormaster completed remote builds in B40290: Diff 91773.Jul 5 2021, 10:50 AM

emaste added inline comments.Jul 5 2021, 1:09 PM

share/mk/bsd.lib.mk
573–577 ↗	(On Diff #91773)	repeated section?

arichardson added inline comments.Jul 5 2021, 1:16 PM

share/mk/bsd.dep.mk
186	Should not be part of this commit. will update
share/mk/bsd.lib.mk
573–577 ↗	(On Diff #91773)	Looks like I accidentally included some stuff from my WIP MSAN support branch.

remove unncessary patterns

Harbormaster completed remote builds in B40307: Diff 91795.Jul 5 2021, 1:28 PM

arichardson added inline comments.Jul 5 2021, 1:30 PM

share/mk/bsd.dep.mk
177	Hmm actually I guess this should be `${OBJS:S/^${_D}.pieo$//}`?

Fix SOBJS->OBJS and modifying the wrong meta.* file

Harbormaster completed remote builds in B41403: Diff 94717.Sep 6 2021, 9:35 AM

arichardson retitled this revision from Add missing dep patterns for .pieo and .nosspico to Add missing dep patterns for .pieo.Sep 6 2021, 9:35 AM

arichardson edited the summary of this revision. (Show Details)

ping?

emaste accepted this revision.Sep 13 2021, 11:54 AM

This revision is now accepted and ready to land.Sep 13 2021, 11:54 AM

imp accepted this revision.Sep 13 2021, 12:18 PM

Closed by commit rG2d78130185b5: Add missing dep patterns for .pieo (authored by arichardson). · Explain WhySep 13 2021, 12:23 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG2d78130185b5: Add missing dep patterns for .pieo.

arichardson added a commit: rGcbbdacf4dc8f: Add missing dep patterns for .pieo.May 7 2022, 3:57 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

5 lines

local.autodep.mk

3 lines

Diff 95035

share/mk/bsd.dep.mk

Loading...

share/mk/local.autodep.mk

Loading...