Page MenuHomeFreeBSD
Differential D31017

loader: Don't reserve space for symbols twice.
ClosedPublic
Actions

Authored by imp on Jul 4 2021, 4:11 PM.
Tags
None
Referenced Files
F102389088: D31017.id91719.diff
Mon, Nov 11, 2:42 PM
F102370188: D31017.id92122.diff
Mon, Nov 11, 8:18 AM
F102362209: D31017.id91721.diff
Mon, Nov 11, 5:49 AM
Unknown Object (File)
Mon, Nov 11, 12:43 AM
Unknown Object (File)
Mon, Nov 11, 12:18 AM
Unknown Object (File)
Mon, Nov 4, 3:39 PM
Unknown Object (File)
Mon, Nov 4, 2:10 PM
Unknown Object (File)
Sep 24 2024, 2:21 PM
View All 46 Files
Subscribers
dab

Details

Reviewers
jhb
neel
Commits
rG1e1d3725569f: loader: Don't reserve space for symbols twice.
rG297e9f364b5a: loader: Don't reserve space for symbols twice.
Summary

The current code bumps lastaddr twice for the symbol table
location. However, the first bump is bogus and results in wasted
space. Remove it.

PR: 110995

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 4 2021, 4:11 PM
Herald added a subscriber: dab. · View Herald TranscriptJul 4 2021, 4:11 PM
imp requested review of this revision.Jul 4 2021, 4:11 PM
Harbormaster completed remote builds in B40260: Diff 91719.Jul 4 2021, 4:11 PM
imp edited the summary of this revision. (Show Details)Jul 4 2021, 4:13 PM
imp added a reviewer: jhb.
imp added inline comments.Jul 4 2021, 4:34 PM
stand/common/load_elf_obj.c
293–295

I think we already do the stuff above here, so we can just do these lines and omit them above.

imp retitled this revision from don't load symbol table into memory to loader: Don't reserve space for symbols twice..Jul 4 2021, 4:40 PM
imp edited the summary of this revision. (Show Details)
imp added a reviewer: neel.
imp updated this revision to Diff 91721.Jul 4 2021, 5:10 PM
imp edited the summary of this revision. (Show Details)

actually remove... no need to comment these redunant lines out.

Harbormaster completed remote builds in B40262: Diff 91721.Jul 4 2021, 5:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2021, 9:31 PM
Closed by commit rG297e9f364b5a: loader: Don't reserve space for symbols twice. (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG297e9f364b5a: loader: Don't reserve space for symbols twice..
imp added a commit: rG1e1d3725569f: loader: Don't reserve space for symbols twice..Jul 16 2021, 6:33 PM

Revision Contents
Changeset List

PathSize
stand/
common/
2 lines

Diff 92122

View Options

stand/common/load_elf_obj.c

Loading...