Page MenuHomeFreeBSD

amd64: a simplication to pmap_remove_{all,write}
ClosedPublic

Authored by alc on Jun 30 2021, 5:58 AM.
Tags
None
Referenced Files
F112051662: D30951.id91580.diff
Wed, Mar 12, 3:19 AM
Unknown Object (File)
Fri, Mar 7, 5:21 AM
Unknown Object (File)
Mon, Feb 24, 6:01 AM
Unknown Object (File)
Sun, Feb 23, 8:58 AM
Unknown Object (File)
Mon, Feb 17, 11:37 AM
Unknown Object (File)
Sun, Feb 16, 12:41 PM
Unknown Object (File)
Fri, Feb 14, 8:09 PM
Unknown Object (File)
Feb 3 2025, 12:01 PM
Subscribers
None

Details

Summary

Eliminate some unnecessary unlocking and relocking when we have to retry the operation to avoid deadlock. (All of the other pmap functions that iterate over a PV list already implemented retries without these same unlocking and relocking operations.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc requested review of this revision.Jun 30 2021, 5:58 AM
alc created this revision.
kib added inline comments.
sys/amd64/amd64/pmap.c
8509

Why did you left out the spin chunk from there? Because it would require larger change to fcmset to re-read oldpte to avoid loosing PG_M?

This revision is now accepted and ready to land.Jun 30 2021, 6:06 AM
alc marked an inline comment as done.Jun 30 2021, 6:11 PM
alc added inline comments.
sys/amd64/amd64/pmap.c
8509

Yes. I'll try doing it separately.

This revision was automatically updated to reflect the committed changes.
alc marked an inline comment as done.