Page MenuHomeFreeBSD
Differential D30452

elfctl: avoid touching file if no change
ClosedPublic
Actions

Authored by emaste on May 25 2021, 2:45 PM.
Tags
None
Referenced Files
F106986374: D30452.id.diff
Wed, Jan 8, 1:45 PM
Unknown Object (File)
Tue, Dec 10, 11:45 PM
Unknown Object (File)
Dec 5 2024, 7:09 AM
Unknown Object (File)
Nov 27 2024, 7:54 AM
Unknown Object (File)
Nov 25 2024, 3:36 AM
Unknown Object (File)
Oct 24 2024, 7:18 PM
Unknown Object (File)
Oct 4 2024, 11:00 PM
Unknown Object (File)
Oct 4 2024, 9:06 PM
View All 77 Files
Subscribers
dgr_semihalf.com
imp
mw
wma

Details

Reviewers
brooks
markj
Commits
rGe048bd5c0954: elfctl: avoid touching file if no change made
rG5ceb90aa667a: elfctl: avoid touching file if no change made
rG3f2508b7f385: elfctl: avoid touching file if no change made
Summary

Suggested by: brooks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.May 25 2021, 2:45 PM
emaste created this revision.
markj accepted this revision.May 25 2021, 3:11 PM
markj added inline comments.
usr.bin/elfctl/elfctl.c
314

I am surprised that we do not use libelf to write the update.

This revision is now accepted and ready to land.May 25 2021, 3:11 PM
emaste added a subscriber: mw.May 25 2021, 5:06 PM
emaste added subscribers: dgr_semihalf.com, wma.
emaste added inline comments.May 25 2021, 6:33 PM
usr.bin/elfctl/elfctl.c
314

I am surprised that we do not use libelf to write the update.

Yeah, we could; libelf doesn't really provide much in the way of convenience functions for accessing or modifying individual notes, but we could operate on the note section in memory and use libelf to write it back out.

brooks accepted this revision.May 25 2021, 8:41 PM

I briefly considered the possibility that there might want to be some sort of force flag, but I don't see a lot of value.

Closed by commit rG3f2508b7f385: elfctl: avoid touching file if no change made (authored by emaste). · Explain WhyMay 26 2021, 2:13 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG3f2508b7f385: elfctl: avoid touching file if no change made.
emaste added a comment.May 26 2021, 7:40 PM

I briefly considered the possibility that there might want to be some sort of force flag, but I don't see a lot of value.

Yeah, I gave that some brief thought too, and couldn't see a real use.

emaste added a commit: rG5ceb90aa667a: elfctl: avoid touching file if no change made.Jun 2 2021, 2:09 AM
emaste added a commit: rGe048bd5c0954: elfctl: avoid touching file if no change made.Dec 12 2021, 7:02 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 12 2021, 7:02 PM

Revision Contents
Changeset List

PathSize
usr.bin/
elfctl/
6 lines

Diff 89902

View Options

usr.bin/elfctl/elfctl.c

Loading...