Page MenuHomeFreeBSD

Restore RFC reference
ClosedPublic

Authored by zlei on May 21 2021, 6:43 AM.
Tags
None
Referenced Files
F102118738: D30374.id89672.diff
Thu, Nov 7, 8:38 PM
Unknown Object (File)
Wed, Oct 16, 5:16 AM
Unknown Object (File)
Oct 6 2024, 3:56 AM
Unknown Object (File)
Oct 3 2024, 2:47 AM
Unknown Object (File)
Oct 2 2024, 11:21 PM
Unknown Object (File)
Oct 2 2024, 1:39 PM
Unknown Object (File)
Oct 1 2024, 12:09 AM
Unknown Object (File)
Sep 30 2024, 7:46 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei requested review of this revision.May 21 2021, 6:43 AM
This revision is now accepted and ready to land.May 21 2021, 8:09 AM

FreeBSD src repository favors detailed commit message. I'm not sure if it is sufficient. Suggestions are welcomed :)

Though I am not a big fan of these, as the src tree would need a massive quantity of these added to make much of a dent at all in documenting what part of what rfc is being implemented, I wont stand in the way of one more near useless comment.

karels added a subscriber: karels.

I think the change is useful. The RFC reference could be superseded, but that might also mean the code should be updated as well. It's reasonable to document which version was referenced for the code.

Who is going to commit this?
May I? I'd combine both patches into a single MFC action.

I echo karels' comments that reinstating this provides a reference that one can use for added context, as well as something that acts as a reminder to keep code up-to-date with industry changes. I support re-adding this.

This revision was automatically updated to reflect the committed changes.