Page MenuHomeFreeBSD

cam: introduce xpt_setup_stack_ccb
AbandonedPublic

Authored by imp on May 20 2021, 2:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 8:53 AM
Unknown Object (File)
Oct 2 2024, 8:56 AM
Unknown Object (File)
Sep 18 2024, 9:18 AM
Unknown Object (File)
Sep 5 2024, 6:36 AM
Unknown Object (File)
Sep 5 2024, 12:26 AM
Unknown Object (File)
Aug 31 2024, 8:02 AM
Unknown Object (File)
Aug 31 2024, 8:02 AM
Unknown Object (File)
Aug 31 2024, 8:02 AM
Subscribers

Details

Reviewers
trasz
slm
Group Reviewers
cam
Summary

Create a new function xpt_setup_stack_ccb which is used to setup a ccb
that lives on the stack.

Sponsored by: Netflix

Test Plan

This is a thought experiment on how one might create a safer version of this that we could assert on later.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39316
Build 36205: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 20 2021, 2:15 AM
imp edited the test plan for this revision. (Show Details)

Add malloc tagging and add assert to xpt_setup_ccb

Note: this just does scsi_da.c as a proof of concept, but doesn't go through the tree yet.

This comment was removed by imp.

https://reviews.freebsd.org/D30353 has all the other changes, and a good coccinelle script for spatch

tweak the script to eliminate a couple of bugs

oops, regen with right patch

assert we're not freeing a stack thing
Get the names of the field right

I still like this idea, but I think that I'm just going to punt on this detail