Page MenuHomeFreeBSD

netgraph/ng_base: Renaming a node to the same name is a noop
ClosedPublic

Authored by donner on May 4 2021, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2025, 7:59 PM
Unknown Object (File)
Feb 22 2025, 12:53 AM
Unknown Object (File)
Feb 21 2025, 7:24 AM
Unknown Object (File)
Feb 10 2025, 8:59 AM
Unknown Object (File)
Feb 9 2025, 5:43 PM
Unknown Object (File)
Feb 6 2025, 3:46 AM
Unknown Object (File)
Feb 4 2025, 12:39 AM
Unknown Object (File)
Feb 1 2025, 7:06 AM

Details

Summary

Detailed analysis in https://github.com/genneko/freebsd-vimage-jails/issues/2
brought the problem down to a double call of ng_node_name() before and
after a vnet move. Because the name of the node is already known
(occupied by itself), the second call fails.

PR: 241954
Reported by: Paul Armstrong
MFC: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

donner requested review of this revision.May 4 2021, 7:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 4 2021, 9:22 AM
This revision was automatically updated to reflect the committed changes.