lib/msun: Exclude ignored-pragmas from -Werror
ClosedPublic
Actions

Authored by arichardson on Apr 13 2021, 11:59 AM.

Details

Reviewers

dim
emaste

Commits

rGdd9c06d0a662: lib/msun: Exclude ignored-pragmas from -Werror
rGa6898ea04e4d: lib/msun: Exclude ignored-pragmas from -Werror
rG168234fa67c3: lib/msun: Exclude ignored-pragmas from -Werror

Summary

This avoids build failures due to the clang 12 warning:

'#pragma FENV_ACCESS' is not supported on this target - ignored

Test Plan

compiles with clang12

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Apr 13 2021, 11:59 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 13 2021, 11:59 AM

arichardson requested review of this revision.Apr 13 2021, 11:59 AM

Harbormaster completed remote builds in B38556: Diff 87371.Apr 13 2021, 11:59 AM

Is this now on e.g. PowerPC etc? Or also on x86? But in any case, LGTM.

This revision is now accepted and ready to land.Apr 13 2021, 1:34 PM

emaste accepted this revision.Apr 13 2021, 1:40 PM

I saw this building CheriBSD, and I think it affected almost all architectures.

Ah, I thought maybe now that the StrictFP stuff is operational we might finally get some #pragma FENV_ACCESS support, but it's probably a whole other can of worms...

Looks like the warning is not triggered for x86, only other architectures. That indicates that the pragmas might actually be implemented now.
Should I restrict the -Wno-error to non-x86?

Closed by commit rG168234fa67c3: lib/msun: Exclude ignored-pragmas from -Werror (authored by arichardson). · Explain WhyApr 15 2021, 3:28 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG168234fa67c3: lib/msun: Exclude ignored-pragmas from -Werror.

arichardson added a commit: rGa6898ea04e4d: lib/msun: Exclude ignored-pragmas from -Werror.Apr 22 2021, 11:10 AM

dim added a commit: rGdd9c06d0a662: lib/msun: Exclude ignored-pragmas from -Werror.Dec 25 2021, 11:59 AM