Page MenuHomeFreeBSD

traceroute6: Fix rights for rcvsock
ClosedPublic

Authored by markj on Mar 31 2021, 10:41 PM.
Tags
None
Referenced Files
F102555905: D29523.id86648.diff
Thu, Nov 14, 12:30 AM
Unknown Object (File)
Tue, Nov 12, 12:50 PM
Unknown Object (File)
Sat, Oct 26, 5:18 AM
Unknown Object (File)
Sat, Oct 26, 5:18 AM
Unknown Object (File)
Sat, Oct 26, 5:18 AM
Unknown Object (File)
Sat, Oct 26, 5:17 AM
Unknown Object (File)
Fri, Oct 25, 2:10 PM
Unknown Object (File)
Sep 29 2024, 2:29 AM
Subscribers

Details

Summary
  • Always use distinct sockets for send and recv
  • Limit rights on the recv socket
  • Limit rights before entering capability mode

For ICMP6 we were using the same socket for both, and we limited rights
on the socket such that it's impossible to receive anything.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei added inline comments.
usr.sbin/traceroute6/traceroute6.c
942

Copy paste typo

947

It looks good entering capability mode before limiting rights. So no need to adjust here.

After addressing @zlei.huang_gmail.com points - LGTM.

markj marked an inline comment as done.

Address feedback.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2021, 2:01 PM
This revision was automatically updated to reflect the committed changes.