Page MenuHomeFreeBSD
Differential D29511

powerpc64: add missing TLB invalidations to radix
ClosedPublic
Actions

Authored by luporl on Mar 31 2021, 12:12 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Nov 6, 12:40 AM
Unknown Object (File)
Mon, Nov 4, 9:53 PM
Unknown Object (File)
Fri, Oct 25, 1:56 PM
Unknown Object (File)
Tue, Oct 22, 7:58 PM
Unknown Object (File)
Tue, Oct 22, 7:45 PM
Unknown Object (File)
Tue, Oct 22, 6:52 PM
Unknown Object (File)
Tue, Oct 22, 11:34 AM
Unknown Object (File)
Oct 5 2024, 8:42 PM
View All 67 Files
Subscribers
alfredo
imp
jhibbits
Contributor Reviews (src)

Details

Reviewers
bdragon
jhibbits
Group Reviewers
PowerPC
Commits
rG019cdd20bbd3: powerpc64: add missing TLB invalidations to radix
rG28d14569c873: powerpc64: add missing TLB invalidations to radix
Summary

Radix MMU code was missing TLB invalidations when some Level 3 PDEs were modified.
This caused TLB multi-hit machine check interrupts when superpages were enabled.

Test Plan

Built p5-Lingua-EN-Tagger port several times and performed a buildworld without receiving TLB multi-hit machine checks.

To test system stability, a poudriere bulk build was left running for 4 days, resulting in more than 6000 packages built, 6007 skipped, 14 failed and no TLB multi-hits.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

luporl created this revision.Mar 31 2021, 12:12 PM
Herald added subscribers: Contributor Reviews (src), jhibbits, imp. · View Herald TranscriptMar 31 2021, 12:12 PM
luporl requested review of this revision.Mar 31 2021, 12:12 PM
Harbormaster completed remote builds in B38210: Diff 86607.Mar 31 2021, 12:12 PM
luporl added reviewers: bdragon, jhibbits, PowerPC.Mar 31 2021, 12:13 PM
luporl added a project: PowerPC.
Herald added a subscriber: alfredo. · View Herald TranscriptMar 31 2021, 12:13 PM
jhibbits added inline comments.Mar 31 2021, 2:14 PM
sys/powerpc/aim/mmu_radix.c
5229

Can you just set anyvalid=true here, and invalidate everything at the end as it's already done?

luporl updated this revision to Diff 86851.Apr 5 2021, 6:00 PM
luporl edited the test plan for this revision. (Show Details)

Address jhibbits' comments

Harbormaster completed remote builds in B38327: Diff 86851.Apr 5 2021, 6:00 PM
luporl marked an inline comment as done.Apr 5 2021, 6:01 PM
jhibbits accepted this revision.Apr 5 2021, 6:45 PM
This revision is now accepted and ready to land.Apr 5 2021, 6:45 PM
Closed by commit rG28d14569c873: powerpc64: add missing TLB invalidations to radix (authored by luporl). · Explain WhyApr 6 2021, 11:43 AM
This revision was automatically updated to reflect the committed changes.
luporl added a commit: rG28d14569c873: powerpc64: add missing TLB invalidations to radix.
luporl added a commit: rG019cdd20bbd3: powerpc64: add missing TLB invalidations to radix.Apr 22 2021, 2:32 PM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
aim/
5 lines

Diff 86896

View Options

sys/powerpc/aim/mmu_radix.c

Loading...