Page MenuHomeFreeBSD
Differential D29331

Fix TSO for TCP/IPv6
ClosedPublic
Actions

Authored by tuexen on Mar 18 2021, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 9:33 PM
Unknown Object (File)
Tue, Nov 12, 9:33 PM
Unknown Object (File)
Sun, Nov 10, 11:29 PM
Unknown Object (File)
Sun, Nov 10, 11:29 PM
Unknown Object (File)
Sun, Nov 10, 11:25 PM
Unknown Object (File)
Sun, Nov 10, 11:22 PM
Unknown Object (File)
Oct 19 2024, 2:54 AM
Unknown Object (File)
Oct 17 2024, 12:23 AM
View All 57 Files
Subscribers
None

Details

Reviewers
bryanv
Commits
rG11660fa28fd3: vtnet: fix TSO for TCP/IPv6
rG6064ea8172f0: vtnet: fix TSO for TCP/IPv6
rGd4697a6b5616: vtnet: fix TSO for TCP/IPv6
Summary

The decision whether a TCP packet is sent over IPv4 or IPv6 was based on ethertype, which works correctly.
In D27926 the criteria was changed to checking if the CSUM_IP_TSO flag is set in the csum-flags and then considering it to be TCP/IPv4.

However, the TCP stack sets the flag to CSUM_TSO for IPv4 and IPv6, where CSUM_TSO is defined as CSUM_IP_TSO|CSUM_IP6_TSO.
Therefore TCP/IPv6 packets gets mis-classified as TCP/IPv4, which breaks TSO for TCP/IPv6.

This patch bases the check again on the ethertype.

This fixes the bug reported in PR254366.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen requested review of this revision.Mar 18 2021, 7:59 PM
tuexen created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2021, 8:33 PM
Closed by commit rGd4697a6b5616: vtnet: fix TSO for TCP/IPv6 (authored by tuexen). · Explain Why
This revision was automatically updated to reflect the committed changes.
tuexen added a commit: rGd4697a6b5616: vtnet: fix TSO for TCP/IPv6.
tuexen added a commit: rG6064ea8172f0: vtnet: fix TSO for TCP/IPv6.
tuexen added a commit: rG11660fa28fd3: vtnet: fix TSO for TCP/IPv6.Mar 18 2021, 8:41 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
virtio/
network/
8 lines

Diff 85992

View Options

sys/dev/virtio/network/if_vtnet.c

Loading...