Page MenuHomeFreeBSD

systat: Avoid incorrect reallocation in pigs.c
ClosedPublic

Authored by ota_j.email.ne.jp on Mar 17 2021, 12:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 9:03 AM
Unknown Object (File)
Feb 25 2025, 2:04 AM
Unknown Object (File)
Feb 20 2025, 7:15 PM
Unknown Object (File)
Feb 10 2025, 2:51 PM
Unknown Object (File)
Jan 22 2025, 3:26 PM
Unknown Object (File)
Jan 20 2025, 1:08 PM
Unknown Object (File)
Jan 17 2025, 1:36 PM
Unknown Object (File)
Jan 17 2025, 1:31 PM

Details

Summary

Let's say nproc comes back in 3, 1, 2, the reallocation happens on the 3rd
fetch given lastnproc 1 is smaller than nproc 2. However, we reserved 3 slots
and thus don't need to reallocate.

Stop free() even if kvm_getprocs as we can come back but set nprocs = 0.
Check nprocs in showpigs() to ensure not try displaying with kvm_getprocs failed.
Current code can have pt with non-null after kvm_getprocs() failure.

Replace to realloc for simpler operations.

Test Plan

% systat -pigs

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable