Page MenuHomeFreeBSD
Differential D29137

usr.sbin/pwm/pwm add support for flags
ClosedPublic
Actions

Authored by oskar.holmlund_ohdata.se on Mar 9 2021, 8:28 AM.
Tags
Referenced Files
F115929117: D29137.diff
Wed, Apr 30, 1:12 PM
F115927599: D29137.id.diff
Wed, Apr 30, 12:51 PM
Unknown Object (File)
Tue, Apr 22, 4:51 PM
Unknown Object (File)
Tue, Apr 22, 8:40 AM
Unknown Object (File)
Sun, Apr 20, 1:34 PM
Unknown Object (File)
Sat, Apr 19, 8:10 AM
Unknown Object (File)
Thu, Apr 17, 9:43 AM
Unknown Object (File)
Thu, Apr 17, 3:08 AM
View All Files
Subscribers
lwhsu

Details

Reviewers
manu
Commits
rG120e7f7399fc: usr.sbin/pwm/pwm add support for flags
rG17b14d8f7733: usr.sbin/pwm/pwm add support for flags
Summary

The pwm utility cant set the only flag defined (PWM_POLARITY_INVERTED) so this patch add the option -I (capital letter i) to send it to the drivers.

None of existing PWM driver have implemented support for flags. But soon:ish I will put up an review of a pwm driver using TI OMAP DMTimer.

Also fix the types of period and duty in share/man/man9/pwmbus.9 to match the one in sys/dev/pmw/pwmbus.c.

Test Plan

Tested on BBB with

  • ti_omap_dmtimer_pwm [not published] have support for flags
  • am335x_ehrpwm does not have support for flags

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

oskar.holmlund_ohdata.se requested review of this revision.Mar 9 2021, 8:28 AM
oskar.holmlund_ohdata.se created this revision.
lwhsu added a subscriber: lwhsu.Mar 9 2021, 8:54 AM

.dD field in manual page needs to be updated.

manu added a comment.Mar 9 2021, 9:00 AM

Looks ok, could you split the updated man page change not related with this review ?

usr.sbin/pwm/pwm.c
185

whitespace are needed here " & "

oskar.holmlund_ohdata.se updated this revision to Diff 85372.Mar 9 2021, 10:02 AM

Remove share/man/man9/pwmbus.9
Fix space around &

oskar.holmlund_ohdata.se marked an inline comment as done.Mar 9 2021, 10:02 AM
oskar.holmlund_ohdata.se added a comment.Mar 9 2021, 10:05 AM
In D29137#652543, @lwhsu wrote:

.dD field in manual page needs to be updated.

Thank you, fixed in D29139

manu accepted this revision.Mar 11 2021, 8:30 AM
This revision is now accepted and ready to land.Mar 11 2021, 8:30 AM
Closed by commit rG17b14d8f7733: usr.sbin/pwm/pwm add support for flags (authored by oskar.holmlund_ohdata.se, committed by manu). · Explain WhyMar 11 2021, 8:59 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG17b14d8f7733: usr.sbin/pwm/pwm add support for flags.
oskar.holmlund_ohdata.se mentioned this in D29546: am335x_ehrpwm.c remove sysctl interface.Apr 2 2021, 9:11 AM
manu added a commit: rG120e7f7399fc: usr.sbin/pwm/pwm add support for flags.Jul 22 2021, 4:41 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
pwm/
19 lines
usr.sbin/
pwm/
3 lines
19 lines

Diff 85372

View Options

sys/dev/pwm/pwmc.c

Loading...
View Options

usr.sbin/pwm/pwm.8

Loading...
View Options

usr.sbin/pwm/pwm.c

Loading...