Page MenuHomeFreeBSD

loader: use display pixel density for font autoselection
ClosedPublic

Authored by tsoome on Feb 22 2021, 9:14 AM.
Tags
None
Referenced Files
F108517320: D28849.id84599.diff
Sat, Jan 25, 7:59 PM
F108514270: D28849.id84522.diff
Sat, Jan 25, 7:35 PM
F108511652: D28849.id84437.diff
Sat, Jan 25, 7:11 PM
Unknown Object (File)
Sat, Jan 25, 11:41 AM
Unknown Object (File)
Sat, Jan 18, 4:49 AM
Unknown Object (File)
Fri, Jan 17, 2:31 PM
Unknown Object (File)
Sun, Jan 12, 3:33 PM
Unknown Object (File)
Mon, Jan 6, 8:19 PM

Details

Summary

Calculate font size from 16 density independent pixels (dp) by using:
size = 16 * ppi/160 * display_factor

We are specifying font size 16dp, and assuming 1dp = 160ppi.
Also apply scaling factor 2 (display_factor).

Test Plan

test with different systems and resolutions

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

use gop_handle, not gop protocol

make it actually to work...

Works for me, now the font seems fine on a 2160p monitor, and there's no black bar at the bottom of the screen.

Don't really have much knowledge in this area to provide a meaningful review I'm afraid.

stand/efi/loader/framebuffer.c
506

size = MAX(sizeof(*edid_infop), edid->SizeOfEdid);

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2021, 9:28 AM
This revision was automatically updated to reflect the committed changes.