amd64: import asm strlen into libc
ClosedPublic
Actions

Authored by mjg on Feb 21 2021, 9:29 PM.

Details

Reviewers

kib
jhb

Commits

rGc16fc9eae3ad: amd64: import asm strlen into libc
rG7f06b217c53c: amd64: import asm strlen into libc

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg requested review of this revision.Feb 21 2021, 9:29 PM

mjg created this revision.

kib added inline comments.Feb 22 2021, 9:51 PM

lib/libc/amd64/string/strlen.S
3	I do not think this is valid notice form about 'public domain'. At very least it should specify who wrote the code and put it into the public domain. Look for other examples in the tree.
15	Why redefining this instead of including machine/asmacros.h ?

update license

Adding the header fails to compile with:

In file included from /usr/src/lib/libc/amd64/string/strlen.S:7:
/usr/include/machine/asm.h:88:9: error: 'ALTENTRY' macro redefined [-Werror,-Wmacro-redefined]
#define ALTENTRY(x)     _ENTRY(x)
        ^

with a host of other errors

Using it instead of asm.h results in:

/usr/src/lib/libc/amd64/string/strlen.S:8:22: error: expected ')' in parentheses expression
__asm__(".ident\t\"" "$FreeBSD$" "\"");
                     ^

someone(tm) needs to clean this up and I don't think it's worth the effort now

kib accepted this revision.Feb 22 2021, 10:57 PM

This revision is now accepted and ready to land.Feb 22 2021, 10:57 PM

Closed by commit rG7f06b217c53c: amd64: import asm strlen into libc (authored by mjg). · Explain WhyFeb 23 2021, 12:11 AM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rG7f06b217c53c: amd64: import asm strlen into libc.

mjg added a commit: rGc16fc9eae3ad: amd64: import asm strlen into libc.Apr 10 2021, 1:59 PM