This quiets a warning when building with GCC.
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 37140 Build 34029: arc lint + arc unit
Event Timeline
This should almost certainly not be committed as-is as it depends on if upstream needs to remove this function or if it is used in some code that isn't merged yet, etc. This function looks to have been introduced in the recent merge in 69d9cc88d213f3d95526636743f15371f2fa6c2c.
I'm obviously not the maintainer but:
This is okay with me if you're eager to get the build going. I just sent a patch to upstream which deletes the function: https://github.com/openzfs/zfs/pull/11614. If they accept that, I'll cherry pick it back.
Yes, looks like Matthew Ahrens has inlined this code into abd_get_offset_scatter()
Thank you @rlibby for submitting the upstream PR.
I'm not super eager to merge this (there are a couple of other reviews I have in flight to fix GCC regressions), just wanted to get it on the radar. I'd rather the upstream fix get cherry-picked back assuming it doesn't take very long to come back.