Page MenuHomeFreeBSD
Differential D28582

Porter's Handbook: Document DISABLE_CONFLICTS and fix a small grammar issue
ClosedPublic
Actions

Authored by jrm on Feb 11 2021, 12:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 4:47 PM
Unknown Object (File)
Sun, Feb 9, 11:51 AM
Unknown Object (File)
Jan 9 2025, 9:05 AM
Unknown Object (File)
Jan 9 2025, 9:05 AM
Unknown Object (File)
Nov 27 2024, 12:45 PM
Unknown Object (File)
Nov 27 2024, 3:55 AM
Unknown Object (File)
Nov 23 2024, 10:05 AM
Unknown Object (File)
Nov 20 2024, 6:01 PM
View All 81 Files
Subscribers
crees
ygy

Details

Reviewers
linimon
mat
crees
ygy
Group Reviewers
Doc Committers
Commits
R9:b7744f2b7581: Porter's Handbook: Document DISABLE_CONFLICTS variable
R9:47dc6685eb77: Porter's Handbook: Tweak conflict instructions

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Feb 11 2021, 12:39 AM
jrm created this revision.
Harbormaster completed remote builds in B36879: Diff 83668.Feb 11 2021, 12:39 AM
jrm retitled this revision from Summary: to Porter's Handbook: Document DISABLE_CONFLICTS and fix a small grammar issue.Feb 11 2021, 12:54 AM
jrm edited the summary of this revision. (Show Details)
crees requested changes to this revision.Feb 13 2021, 8:36 PM
crees added a subscriber: crees.
crees added inline comments.
documentation/content/en/books/porters-handbook/makefiles/chapter.adoc
4611

some versions of another port are

This revision now requires changes to proceed.Feb 13 2021, 8:36 PM
jrm updated this revision to Diff 83860.Feb 14 2021, 2:32 AM

I think this sentence can be improved, but I'm not sure if this suggestion is
correct. Only some version is the subject and it's (awkwardly) singular, so the
verb should be is and not are. Here is my attempt at improving the wording.

Harbormaster completed remote builds in B36982: Diff 83860.Feb 14 2021, 2:32 AM
jrm added inline comments.Feb 14 2021, 2:34 AM
documentation/content/en/books/porters-handbook/makefiles/chapter.adoc
4611

Oh sorry. I just read your suggestion more carefully and I now see you that said Some versions...are. That makes sense.

jrm updated this revision to Diff 83861.Feb 14 2021, 2:35 AM

Another wording tweak.

Harbormaster completed remote builds in B36983: Diff 83861.Feb 14 2021, 2:35 AM
ygy accepted this revision.Feb 19 2021, 3:07 PM
ygy added a subscriber: ygy.

LGTM on the doc side, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 3:46 PM
Closed by commit R9:47dc6685eb77: Porter's Handbook: Tweak conflict instructions (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R9:47dc6685eb77: Porter's Handbook: Tweak conflict instructions.
jrm added a commit: R9:b7744f2b7581: Porter's Handbook: Document DISABLE_CONFLICTS variable.

Revision Contents
Changeset List

PathSize
documentation/
content/
en/
books/
porters-handbook/
makefiles/
2 lines

Diff 84275

View Options

documentation/content/en/books/porters-handbook/makefiles/chapter.adoc

Loading...