1300134 broke bsdrcmds when support for NO_WERROR=1 was replaced by MK_WERROR=no. This patch fixes the build under 14-CURRENT and 13-ALPHA.
See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253000.
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| net/bsdrcmds/Makefile | ||
|---|---|---|
| 21 ↗ | (On Diff #82941) | I've just tried on 12-1-RELEASE and MK_WERROR=no seems to works. So I believe you can just swap the old one for the new one. |
Comment Actions
Simpler patch uploaded.
| net/bsdrcmds/Makefile | ||
|---|---|---|
| 21 ↗ | (On Diff #82941) | NO_WERROR=1 is still needed for 11-STABLE. And src 7fa2f2a62f04f095e1e27ad55aa22a8f59b1df8f was never MFCed back to stable/12 nor to stable/11. Testing replacing NO_WERROR=1 with MK_WERROR=no on ref12-amd64 causes the build to fail. Similarly on ref11-amd64. Based on my tests on ref12-amd64 and ref11-amd64, and based on review of the logs for stable/12 and stable/11, a wholesale replace of NO_WERROR=1 with MK_WERROR=no will cause the build to break on older FreeBSD. I'll upload a simpler patch. |
Comment Actions
I'm not able to test this on 11-STABLE, but this looks good to me as an unused environment variable should be harmless.