Page MenuHomeFreeBSD
Differential D28331

usr.sbin/pkg: Don't re-define roundup2
ClosedPublic
Actions

Authored by arichardson on Jan 25 2021, 2:42 PM.
Tags
None
Referenced Files
F97651317: D28331.diff
Mon, Sep 30, 2:23 PM
Unknown Object (File)
Fri, Sep 27, 5:38 PM
Unknown Object (File)
Tue, Sep 24, 5:01 AM
Unknown Object (File)
Sat, Sep 21, 11:17 PM
Unknown Object (File)
Sun, Sep 15, 2:40 AM
Unknown Object (File)
Sat, Sep 14, 1:54 PM
Unknown Object (File)
Sat, Sep 14, 1:52 PM
Unknown Object (File)
Thu, Sep 5, 6:41 PM
View All 57 Files
Subscribers
None

Details

Reviewers
bapt
bdrewery
Commits
rGa259db87edfe: usr.sbin/pkg: Don't re-define roundup2
rGc669cd841847: usr.sbin/pkg: Don't re-define roundup2
rG9a0a48b12d3d: usr.sbin/pkg: Don't re-define roundup2
Summary

The file already includes sys/param.h and should use that definition.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36466
Build 33355: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 25 2021, 2:42 PM
Herald added a reviewer: bdrewery. · View Herald TranscriptJan 25 2021, 2:42 PM
arichardson requested review of this revision.Jan 25 2021, 2:42 PM
Harbormaster completed remote builds in B36466: Diff 82846.Jan 25 2021, 2:42 PM
arichardson mentioned this in D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2.Jan 25 2021, 9:22 PM
arichardson added a child revision: D28332: Expose clang's alignment builtins and use them for roundup2/rounddown2.
arichardson added a comment.Jan 28 2021, 5:19 PM

Since this is a trivial cleanup, I'll commit this on Monday unless there's any objection.

bapt accepted this revision.Jan 28 2021, 5:24 PM
This revision is now accepted and ready to land.Jan 28 2021, 5:24 PM
Closed by commit rG9a0a48b12d3d: usr.sbin/pkg: Don't re-define roundup2 (authored by arichardson). · Explain WhyJan 28 2021, 5:41 PM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG9a0a48b12d3d: usr.sbin/pkg: Don't re-define roundup2.
bapt added a commit: rGc669cd841847: usr.sbin/pkg: Don't re-define roundup2.May 5 2021, 8:25 AM
arichardson added a commit: rGa259db87edfe: usr.sbin/pkg: Don't re-define roundup2.Jul 5 2021, 9:47 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
pkg/
2 lines

Diff 82846

View Options

usr.sbin/pkg/config.c

Loading...