Page MenuHomeFreeBSD

epoll: Store epoll_event udata member in ext member of kevent.
ClosedPublic

Authored by wulf on Jan 14 2021, 8:51 PM.
Tags
None
Referenced Files
F102193879: D28169.diff
Fri, Nov 8, 6:58 PM
Unknown Object (File)
Fri, Oct 11, 7:23 AM
Unknown Object (File)
Oct 5 2024, 10:30 PM
Unknown Object (File)
Oct 2 2024, 11:50 PM
Unknown Object (File)
Oct 2 2024, 11:00 PM
Unknown Object (File)
Sep 26 2024, 8:55 PM
Unknown Object (File)
Sep 21 2024, 6:00 AM
Unknown Object (File)
Sep 17 2024, 1:33 AM

Details

Summary

Current epoll implementation stores udata fields of epoll_event
structure in special dynamically-sized table rather than in udata field
of backing kevent structure because of 2 reasons:

  1. Kevent's udata size is smaller than epoll's on 32-bit archs.
  2. Kevent's udata can be clobbered on execution EPOLL_CTL_ADD as kqueue modifies existing event while epoll returns error in this case.

After r320043 has introduced 4 new 64bit user data members (ext[]),
we can store epoll udata in one of them and drop aforementioned table.
According to kqueue_register() source code ext members are not updated
when existing kevent is modified that fixes p.2.

As a side effect the patch fixes PR/252582.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable