Fix a vnode locking bug in fuse_vnop_advlock.
It was introduced by subversion r346170.
MFC after: 2 weeks
Differential D27936
Fix a vnode locking bug in fuse_vnop_advlock. asomers on Jan 2 2021, 11:13 PM. Authored by Tags None Referenced Files
Subscribers
Details Fix a vnode locking bug in fuse_vnop_advlock. It was introduced by subversion r346170. MFC after: 2 weeks Existing test suite with DEBUG_VFS_LOCKS
Diff Detail
Event TimelineComment Actions Ok, so the bug was that we never took any lock at all? But we're also moving a block of code surrounding the new vn_lock(); operation, which isn't related to our not-locking-the-vp-bug. It looks like we want to reject EINVAL flags before we start locking, which is fine. I would just like to see a better commit message than "fix a [non-specific] bug." Something like "add missing lock in fuse advlock. also, reject invalid parameters sooner (style)."
|