Page MenuHomeFreeBSD

pf: Fix table entry counter toggling
ClosedPublic

Authored by markj on Dec 1 2020, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 10 2024, 5:03 AM
Unknown Object (File)
Nov 29 2024, 8:25 AM
Unknown Object (File)
Nov 28 2024, 1:16 PM
Unknown Object (File)
Nov 22 2024, 3:59 AM
Unknown Object (File)
Nov 12 2024, 2:47 AM
Unknown Object (File)
Nov 7 2024, 2:33 PM
Unknown Object (File)
Nov 7 2024, 1:33 AM
Unknown Object (File)
Oct 29 2024, 11:44 AM

Details

Summary

When updating a table, pf will keep table entry structures corresponding
to addresses that are in both of the old and new tables. However, the
update may also enable or disable per-entry counters which are allocated
separately. Thus when toggling PFR_TFLAG_COUNTERS, the entries may be
missing counters or may have unused counters allocated.

Fix the problem by modifying pfr_ina_commit() to transfer counters
from or to the shadow table.

Reported by: sigsys@gmail.com

Test Plan

Regression tests pass. I will write a test case for this if the code change seems ok.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable