malloc: move malloc_type_internal into malloc_type
ClosedPublic
Actions

Authored by mjg on Nov 5 2020, 1:37 PM.

Details

Reviewers

Commits

rS367432: malloc: move malloc_type_internal into malloc_type

Summary

According to code comments the original motivation was to allow for malloc_type_internal changes without ABI breakage. This can be trivially accomplished by providing spare fields and versioning the struct, as implemented in the patch below.

The upshots are one less memory indirection on each alloc and disappearance of mt_zone.

Test Plan

Booted, vmstat -M /dev/mem -m and vmstat -m agree.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Nov 5 2020, 1:37 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 5 2020, 1:37 PM

Harbormaster completed remote builds in B34648: Diff 79210.Nov 5 2020, 1:37 PM

mjg requested review of this revision.Nov 5 2020, 1:37 PM

markj added inline comments.Nov 5 2020, 1:51 PM

sys/sys/malloc.h
118 ↗	(On Diff #79210)	What's the purpose of having two structures with the same visibility?
143 ↗	(On Diff #79210)	Would be nice to convert to C99 initializers while you're here.

mjg added inline comments.Nov 5 2020, 1:57 PM

sys/sys/malloc.h
118 ↗	(On Diff #79210)	It's less churn vs the current code and I like some level of logical separation still provided. Regardless, if you insist, I fold the content into the malloc_type itself.
143 ↗	(On Diff #79210)	will do