Page MenuHomeFreeBSD
Differential D26014

emulators/virtualbox-ose-additions: Fix build on HEAD after r363894
AbandonedPublic
Actions

Authored by madpilot on Aug 9 2020, 4:27 PM.
Tags
None
Referenced Files
F103054843: D26014.diff
Wed, Nov 20, 8:30 AM
Unknown Object (File)
Mon, Nov 18, 2:08 AM
Unknown Object (File)
Sun, Nov 17, 9:48 PM
Unknown Object (File)
Sun, Nov 17, 8:03 PM
Unknown Object (File)
Sun, Nov 17, 6:11 PM
Unknown Object (File)
Sun, Nov 17, 5:44 PM
Unknown Object (File)
Sun, Nov 17, 5:25 PM
Unknown Object (File)
Sun, Nov 17, 4:47 PM
View All 41 Files
Subscribers
mat

Details

Reviewers
kevans
Group Reviewers
vbox
Summary
emulators/virtualbox-ose-additions: Fix build on HEAD after r363894

base r363894 removed the privused argument to vaccess(9), this patch
adapt the vboxfs code.

PR: 248528
Differential_Revision: D26014
Test Plan

testport: OK (poudriere)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 32906
Build 30304: arc lint + arc unit

Event Timeline

madpilot created this revision.Aug 9 2020, 4:27 PM
Herald added a subscriber: mat. · View Herald TranscriptAug 9 2020, 4:27 PM
Harbormaster completed remote builds in B32888: Diff 75626.Aug 9 2020, 4:27 PM
madpilot requested review of this revision.Aug 9 2020, 4:27 PM
koobs added a reviewer: kevans.Aug 10 2020, 3:53 AM
koobs retitled this revision from Fix virtualbox-ose-addintions build on HEAD after r363894 to emulators/virtualbox-ose-additions: Fix build on HEAD after r363894.
koobs edited the summary of this revision. (Show Details)
koobs edited the test plan for this revision. (Show Details)
kevans added a comment.Aug 10 2020, 1:14 PM

Seems reasonable to me; we'll want to re-test against base >= rS364080 to make sure we're not getting hit by some of the more recent vfs changes as well.

madpilot planned changes to this revision.Aug 11 2020, 7:57 AM
In D26014#577092, @kevans wrote:

Seems reasonable to me; we'll want to re-test against base >= rS364080 to make sure we're not getting hit by some of the more recent vfs changes as well.

I see, unluckily I will be unable to perform such testing until next week at best.

A slightly modified patch has been proposed in bug 248528. I'm going to update this review shortly so they are aligned,

madpilot updated this revision to Diff 75662.Aug 11 2020, 8:03 AM

Import modified patch from bug 248528.

Harbormaster completed remote builds in B32906: Diff 75662.Aug 11 2020, 8:03 AM
madpilot abandoned this revision.Aug 15 2020, 4:21 PM

Patch to the same effect haas been committed in rP544827.

Revision Contents
Changeset List

PathSize
emulators/
virtualbox-ose/
files/
8 lines

Diff 75662

View Options

emulators/virtualbox-ose/files/patch-src_VBox_Additions_freebsd_vboxvfs_vboxvfs__vnops.c

Loading...