ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself
ClosedPublic
Actions

Authored by nc on Jun 11 2020, 3:54 AM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Dec 31, 8:12 PM

	Unknown Object (File)
	Tue, Dec 31, 7:03 PM

	Unknown Object (File)
	Sun, Dec 29, 11:35 AM

	Unknown Object (File)
	Dec 11 2024, 3:57 PM

	Unknown Object (File)
	Dec 9 2024, 1:41 PM

	Unknown Object (File)
	Dec 7 2024, 12:03 AM

	Unknown Object (File)
	Dec 5 2024, 7:19 PM

	Unknown Object (File)
	Nov 30 2024, 10:18 PM

Subscribers

Contributor Reviews (src)

network

Details

Reviewers

donner

Commits

rS362585: ipfw(4): make O_IPVER/ipversion match IPv4 or 6, not just IPv4.

Summary

ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itself.

Submitted by: Neel Chauhan <neel AT neelc DOT org>

Test Plan

Try this rule:

ipfw add 1 deny all from any to any ipversion 4

It should deny IPv4 packets

Or this:

ipfw add 1 deny all from any to any ipversion 6

It should deny IPv6 packets.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nc created this revision.Jun 11 2020, 3:54 AM

Herald added subscribers: Contributor Reviews (src), melifaro, ae, imp. · View Herald TranscriptJun 11 2020, 3:54 AM

nc requested review of this revision.Jun 11 2020, 3:54 AM

Good catch.

This revision is now accepted and ready to land.Jun 23 2020, 8:31 AM

nc abandoned this revision.Jun 24 2020, 2:25 PM

markj added a commit: rS362585: ipfw(4): make O_IPVER/ipversion match IPv4 or 6, not just IPv4..Jun 24 2020, 3:46 PM

nc reclaimed this revision.Jun 24 2020, 4:58 PM

This revision is now accepted and ready to land.Jun 24 2020, 4:58 PM

nc closed this revision.Jun 24 2020, 4:58 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_fw2.c

2 lines

Diff 72967

View Options

ipfw(4): make O_IPVER/ipversion match IPv4 or IPv6, not just IPv4 by itselfClosedPublicActions