Page MenuHomeFreeBSD

Preparation for BBR and Rack update.
ClosedPublic

Authored by rrs on Apr 26 2020, 3:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 4:34 AM
Unknown Object (File)
Wed, Nov 6, 3:31 AM
Unknown Object (File)
Wed, Nov 6, 1:43 AM
Unknown Object (File)
Sep 24 2024, 5:21 PM
Unknown Object (File)
Sep 23 2024, 9:04 PM
Unknown Object (File)
Sep 19 2024, 3:54 PM
Unknown Object (File)
Sep 17 2024, 2:41 PM
Unknown Object (File)
Sep 7 2024, 8:40 PM
Subscribers

Details

Summary

This patch provides the first preparation step in getting ready to integrate the latest BBR and Rack from NF.
It adds:

  1. New tcp log values and options
  2. Adds a new concept that a stack can support that will always define the ending sequence in a connection. This can be useful for stacks that use it for BB logging purposes and put out the log on exit to provide a quick reference as to why a tcp stack exited. Of course at this point no one uses it so the code is just "available", though not used.
Test Plan

Validate that nothing breaks in the compile since these functions are preparatory they don't really do anything since no one uses them.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rrs requested review of this revision.Apr 26 2020, 3:10 PM
rrs created this revision.
tcp_subr.c
3472 ↗(On Diff #71004)

You might want to use uint32_t for bit.

3484 ↗(On Diff #71004)

Assuming you use uint32_t for bit, you might want to use 1U instead of 1.

3489 ↗(On Diff #71004)

You might want to use i < TCP_END_BYTE_INFO instead of i<TCP_END_BYTE_INFO.

tcp_subr.c
3472 ↗(On Diff #71004)

ack

3484 ↗(On Diff #71004)

ack

Address all of Michael's comments

This revision is now accepted and ready to land.Apr 27 2020, 2:19 PM