Page MenuHomeFreeBSD
Differential D24413

sockstat: Attach to jail if in new vnet
ClosedPublic
Actions

Authored by freqlabs on Apr 14 2020, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 12:05 AM
Unknown Object (File)
Mon, Nov 4, 12:05 AM
Unknown Object (File)
Mon, Nov 4, 12:05 AM
Unknown Object (File)
Mon, Nov 4, 12:05 AM
Unknown Object (File)
Mon, Nov 4, 12:05 AM
Unknown Object (File)
Sun, Nov 3, 11:44 PM
Unknown Object (File)
Sep 19 2024, 7:22 PM
Unknown Object (File)
Sep 19 2024, 6:16 PM
View All 49 Files
Subscribers
afedorov
bcr
imp
mateusz_serveraptor.com
mav
mmacy

Details

Reviewers
bz
jamie
mmacy
Group Reviewers
manpages
Commits
rS360601: MFC r360356:
rS360356: sockstat: Attach to jail if in new vnet
Summary

Attach sockstat to the specified jail if the jail is in a new vnet.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freqlabs created this revision.Apr 14 2020, 7:44 AM
Herald added a reviewer: manpages. · View Herald TranscriptApr 14 2020, 7:44 AM
Herald added a subscriber: imp. · View Herald Transcript
bcr accepted this revision as: manpages.Apr 14 2020, 8:21 AM
bcr added a subscriber: bcr.

OK from manpages.

mateusz_serveraptor.com added a subscriber: mateusz_serveraptor.com.Apr 15 2020, 9:37 AM
freqlabs updated this revision to Diff 70907.Apr 23 2020, 1:23 PM

Add context.

afedorov added a subscriber: afedorov.Apr 23 2020, 3:15 PM
freqlabs added a reviewer: jamie.Apr 23 2020, 3:35 PM
jamie added a comment.Apr 23 2020, 8:12 PM

It may be a better user interface if "-j" automatically did the right thing - limit output to the specified jail for traditional jails, and attach to vnet jails. So after the jail_getid(), a jail_get() or jail_getv() to fetch the jail's vnet parameter. Then the jail_attach() can happen if the vnet is JAIL_SYS_NEW.

That's not quite perfect, as it wouldn't detect a non-vnet jail that's a child of a vnet jail. But it would seamlessly cover the common cases.

freqlabs updated this revision to Diff 70937.Apr 24 2020, 9:06 AM
freqlabs retitled this revision from sockstat: Add an option for attaching to a jail to sockstat: Attach to jail if in new vnet.
freqlabs edited the summary of this revision. (Show Details)

Integrate with existing -j option, per suggestion by @jamie

jamie accepted this revision.Apr 24 2020, 3:50 PM

Looks good!

This revision is now accepted and ready to land.Apr 24 2020, 3:50 PM
mmacy accepted this revision.Apr 26 2020, 8:33 PM
mmacy added a subscriber: mmacy.

LGTM

Closed by commit rS360356: sockstat: Attach to jail if in new vnet (authored by freqlabs). · Explain WhyApr 26 2020, 8:55 PM
This revision was automatically updated to reflect the committed changes.
freqlabs added a commit: rS360356: sockstat: Attach to jail if in new vnet.
freqlabs added a commit: rS360601: MFC r360356:.May 3 2020, 8:14 AM

Revision Contents
Changeset List

PathSize
head/
usr.bin/
sockstat/
53 lines

Diff 71021

View Options

head/usr.bin/sockstat/sockstat.c

Loading...