Page MenuHomeFreeBSD

Fix epoch-related panic in ipdivert & refactor div_output.
ClosedPublic

Authored by melifaro on Jan 22 2020, 2:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 4 2024, 5:27 PM
Unknown Object (File)
Sep 2 2024, 9:53 AM
Unknown Object (File)
Sep 2 2024, 9:53 AM
Unknown Object (File)
Sep 2 2024, 9:53 AM
Unknown Object (File)
Sep 2 2024, 9:53 AM
Unknown Object (File)
Aug 31 2024, 7:32 AM
Unknown Object (File)
Aug 29 2024, 10:55 AM
Unknown Object (File)
Aug 19 2024, 10:55 AM
Subscribers

Details

Summary

Fix epoch-related panic in ipdivert, ensuring in_broadcast() is called within epoch. This got broken in r353292 back in October 2019.
As recent change requires calling in[6]_output() within epoch, it is easier to widen epoch coverage within div_output() instead of cherry-picking individual functions.

Simplify gigantic div_output() by splitting it into 3 functions, handling preliminary setup, remote "ip[6]_output" case and local "netisr" case. Leave original indenting in most parts to ease diff comparison.
Indentation will be fixed by a followup commit.

Test Plan

Tests are added separately in https://reviews.freebsd.org/D23316.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable