Page MenuHomeFreeBSD

setextattr: Increase stdin buffer size to 4096
ClosedPublic

Authored by freqlabs on Jan 16 2020, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 5:36 PM
Unknown Object (File)
Wed, Mar 5, 10:44 AM
Unknown Object (File)
Tue, Mar 4, 5:30 PM
Unknown Object (File)
Mon, Mar 3, 9:41 PM
Unknown Object (File)
Feb 27 2025, 7:09 PM
Unknown Object (File)
Jan 21 2025, 4:58 AM
Unknown Object (File)
Jan 21 2025, 4:45 AM
Unknown Object (File)
Jan 21 2025, 2:21 AM
Subscribers

Details

Summary

Extended attribute values can potentially be quite large. One test for ZFS is supposed to set a 200MB xattr. However, the buffer size for reading values from stdin with setextattr -i is so small that the test times out waiting for tiny chunks of data to be buffered and appended to an sbuf.

Increasing the buffer size should help alleviate some of the burden of reallocating larger sbufs when writing large extended attributes.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable