Page MenuHomeFreeBSD
Differential D2255

Fix DAD callout locking.
AbandonedPublic
Actions

Authored by markj on Apr 8 2015, 5:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 2:22 PM
Unknown Object (File)
Fri, Dec 27, 10:41 PM
Unknown Object (File)
Fri, Dec 27, 7:06 AM
Unknown Object (File)
Nov 28 2024, 8:24 PM
Unknown Object (File)
Nov 28 2024, 8:24 PM
Unknown Object (File)
Nov 28 2024, 8:23 PM
Unknown Object (File)
Nov 28 2024, 8:23 PM
Unknown Object (File)
Nov 28 2024, 8:03 PM
View All 66 Files
Subscribers
emaste
imp
melifaro

Details

Reviewers
ae
hrs
bz
Summary

We were calling callout_reset(9) and callout_drain(9) on DAD callouts
without the corresponding lock held (Giant). This change fixes that, and
modifies the DAD callout to use the DAD rwlock instead of Giant.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20827
Build 20214: arc lint + arc unit

Event Timeline

markj updated this revision to Diff 4738.Apr 8 2015, 5:19 AM
markj retitled this revision from to Fix DAD callout locking..
markj edited the test plan for this revision. (Show Details)
markj updated this object.
Herald added a subscriber: imp. · View Herald TranscriptApr 8 2015, 5:19 AM
markj updated this revision to Diff 4746.Apr 8 2015, 7:49 PM
  • Don't take the DAD lock when calling callout_drain().
markj added reviewers: ae, hrs, bz.Apr 8 2015, 7:52 PM
emaste added a subscriber: emaste.Nov 15 2018, 8:56 PM

Ping

bz added inline comments.Nov 15 2018, 9:52 PM
sys/netinet6/nd6_nbr.c
1131

Thes 4 lines are just whitespace changes, right?

1435–1437

If that is the case, can we assert it?

markj marked 2 inline comments as done.Nov 15 2018, 10:34 PM
markj added inline comments.
sys/netinet6/nd6_nbr.c
1131

Yes.

1435–1437

I'll just assert it at the beginning of the function.

bz accepted this revision.Nov 15 2018, 10:48 PM

I'll trust you to get the assertion right; sounds good to me.

This revision is now accepted and ready to land.Nov 15 2018, 10:48 PM
markj updated this revision to Diff 50460.Nov 15 2018, 10:55 PM
  • Address review feedback and fix merge conflicts.

I will retest this before committing.

This revision now requires review to proceed.Nov 15 2018, 10:55 PM
Harbormaster completed remote builds in B20827: Diff 50460.Nov 15 2018, 10:55 PM
markj abandoned this revision.Sep 15 2021, 1:08 PM

I forgot about this one. A variant was committed in 9a94097cd0f46aacf688973d15b3b462c79f0008 .

Herald added a subscriber: melifaro. · View Herald TranscriptSep 15 2021, 1:08 PM

Revision Contents
Changeset List

PathSize
sys/
netinet6/
52 lines

Diff 50460

View Options

sys/netinet6/nd6_nbr.c

Loading...