Use locking around version flag updates when handling IN6P_IPV6_V6ONLY.
ClosedPublic
Actions

Authored by markj on Oct 1 2019, 11:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 18, 10:13 PM

	Unknown Object (File)
	Mon, Apr 14, 8:15 AM

	Unknown Object (File)
	Mon, Apr 14, 3:46 AM

	Unknown Object (File)
	Mon, Apr 14, 1:11 AM

	Unknown Object (File)
	Sun, Apr 13, 8:35 PM

	Unknown Object (File)
	Tue, Apr 1, 10:34 AM

	Unknown Object (File)
	Tue, Apr 1, 10:15 AM

	Unknown Object (File)
	Tue, Apr 1, 9:17 AM

View All 38 Files

Subscribers

imp

Details

Reviewers

tuexen
ae
bz

Commits

rS353295: Improve locking in the IPV6_V6ONLY socket option handler.

Summary

I am tracking down a race in this area and noticed this bug. There are
places where we do unlocked reads of the flags, but it is certainly
incorrect to update them without a lock on the PCB.

While here, simplify a comment.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 1 2019, 11:26 PM

Herald added a subscriber: ae. · View Herald TranscriptOct 1 2019, 11:26 PM

Harbormaster completed remote builds in B26820: Diff 62813.Oct 1 2019, 11:26 PM

markj added reviewers: tuexen, ae, bz.Oct 1 2019, 11:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 7 2019, 11:35 PM

Closed by commit rS353295: Improve locking in the IPV6_V6ONLY socket option handler. (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS353295: Improve locking in the IPV6_V6ONLY socket option handler..

Herald added a subscriber: imp. · View Herald TranscriptOct 7 2019, 11:35 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet6/

ip6_output.c

19 lines

Diff 63015

View Options

head/sys/netinet6/ip6_output.c

Use locking around version flag updates when handling IN6P_IPV6_V6ONLY.ClosedPublicActions