Page MenuHomeFreeBSD

create non-recursive boot environments (bectl)
ClosedPublic

Authored by rew on May 11 2019, 8:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 4:18 AM
Unknown Object (File)
Oct 3 2024, 7:33 AM
Unknown Object (File)
Sep 30 2024, 6:06 PM
Unknown Object (File)
Sep 23 2024, 4:07 PM
Unknown Object (File)
Sep 22 2024, 6:57 AM
Unknown Object (File)
Sep 15 2024, 7:04 PM
Unknown Object (File)
Sep 15 2024, 7:04 PM
Unknown Object (File)
Sep 15 2024, 7:04 PM
Subscribers

Details

Summary

bectl advertises that it has the ability to create recursive and non-recursive boot environments. This
patch implements that functionality using the be_create_depth API provided by libbe. With this patch,
bectl now works as bectl(8) describes in regards to creating recursive/non-recursive boot environments.

Test Plan
  1. Create a non-recursive boot environment and ensure it has no child datasets.
  2. Create a recursive boot environment and ensure it has a child dataset.

These tests have been added. The existing tests passed on my machine.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sbin/bectl/bectl.c
227 ↗(On Diff #57324)

I'd go ahead and combine this branch with the branch below, given how similar they are. The be_snapshot invocation still looks OK even if it's snapname != NULL ? snapname : be_active_path(be), though perhaps a little wordy.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2019, 2:03 PM
This revision was automatically updated to reflect the committed changes.