Page MenuHomeFreeBSD

pfsync: Call pfsyncintr() directly from pfsync_msg_intr() rather than scheduling a swi
AbandonedPublic

Authored by kp on Nov 14 2018, 9:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 7:13 PM
Unknown Object (File)
Dec 21 2024, 12:37 AM
Unknown Object (File)
Dec 6 2024, 2:04 AM
Unknown Object (File)
Dec 6 2024, 2:03 AM
Unknown Object (File)
Nov 16 2024, 3:09 PM
Unknown Object (File)
Oct 28 2024, 1:31 AM
Unknown Object (File)
Oct 3 2024, 11:33 PM
Unknown Object (File)
Oct 3 2024, 10:33 AM
Subscribers

Details

Reviewers
None
Group Reviewers
network
Summary

When we're done processing a batch of pfsync_msg we can immediately
proceed to pfsyncintr(), rather than schedule a swi (possibly several
times) during the processing. This reduces the swi scheduling overhead,
and also reduces contention on PFSYNC_LOCK.

Replace pfsync_push() calls in the pfsync_msg_intr() path by simply
setting the PFSYNCF_PUSH flag, because we'll always call pfsyncintr()
later. There's no need to schedule the swi.

In pfsync_q_ins() we don't need to schedule the swi either, because it's
always called through pfsync_msg_intr(), so pfsyncint() is guaranteed to
run.

In all other cases (like when we request an update in response to a
received update) we still schedule the swi. Those flows are unmodified.

Tests show a ~25% improvement in throughput.

Sponsored by: Orange Business Services

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 20815