Page MenuHomeFreeBSD
Differential D1202

cleanup stage-qa Add bash to runtime depends for shell scripts Add shebangfix Add setup.sh to installed files
ClosedPublic
Actions

Authored by sbruno on Nov 20 2014, 8:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 12:36 PM
Unknown Object (File)
Dec 21 2024, 11:30 AM
Unknown Object (File)
Nov 4 2024, 11:31 PM
Unknown Object (File)
Oct 29 2024, 10:21 AM
Unknown Object (File)
Oct 23 2024, 5:09 PM
Unknown Object (File)
Oct 3 2024, 9:32 PM
Unknown Object (File)
Sep 24 2024, 3:14 PM
Unknown Object (File)
Sep 18 2024, 11:10 AM
View All 84 Files
Subscribers
None

Details

Reviewers
sunpoet
bapt
bdrewery
Summary

cleanup stage-qa

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sbruno updated this revision to Diff 2482.Nov 20 2014, 8:08 PM
sbruno retitled this revision from to cleanup stage-qa Add bash to runtime depends for shell scripts Add shebangfix Add setup.sh to installed files.
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added reviewers: bapt, bdrewery, sunpoet.
sunpoet edited edge metadata.Nov 21 2014, 10:07 PM

It passes stage-qa. :)
Thanks!

BTW, I found a typo in distinfo.

  • distinfo (revision 373016)

+++ distinfo (working copy)
@@ -1,2 +1,2 @@
SHA256 (sc_serv2_bsd-latest.tar.gz) = 64fa33496de68c1897c855d5461de7739f0d53e0201694f3094c616443b1acfa
-SIZE (sc_serv2_bsd-lastest.tar.gz) = 3034714
+SIZE (sc_serv2_bsd-latest.tar.gz) = 3034714

audio/shoutcast/Makefile
29

Change space to tab or remove the space to align with next line.

54

Please add *_DEPENDS right after MAINTAINER section to pet portlint.

58

Change space to tab.

60

Change space to tab.

sunpoet accepted this revision.Nov 21 2014, 10:10 PM
sunpoet edited edge metadata.
sunpoet added inline comments.
audio/shoutcast/Makefile
11

Please use "@FreeBSD.org".

This revision is now accepted and ready to land.Nov 21 2014, 10:10 PM
sbruno updated this revision to Diff 2522.Nov 23 2014, 8:55 PM
sbruno edited edge metadata.

Cleanup tabs

s/freebsd/FreeBSD/

Fix name of tar ball in distinfo

Updating D1202: cleanup stage-qa

Add bash to runtime depends for shell scripts

Add shebangfix

Add setup.sh to installed files

This revision now requires review to proceed.Nov 23 2014, 8:55 PM
bapt accepted this revision.Nov 23 2014, 8:58 PM
bapt edited edge metadata.
This revision is now accepted and ready to land.Nov 23 2014, 8:58 PM
sbruno closed this revision.Nov 25 2014, 5:09 PM

committed at svn r373418

Revision Contents
Changeset List

PathSize
audio/
shoutcast/
17 lines
2 lines

Diff 2522

View Options

audio/shoutcast/Makefile

Loading...
View Options

audio/shoutcast/distinfo

Loading...