Since we imported clang 5.0.0, the version check in Makefile.inc1 which
checks whether to use libc++ fires even when the compiler for the target
architecture is gcc 4.2.1. This is because only X_COMPILER_VERSION is
checked. Also check X_COMPILER_TYPE, so it will only use libc++ when an
external gcc toolchain is used.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I confirmed that this mips.mips.buildworld works; the other MIPS builds, PowerPC, and Sparc64 are in progress.
Comment Actions
make tinderbox JFLAG=-j16 TARGETS="mips powerpc sparc64" UNIVERSE_TARGET=buildworld
Ran to completion and passed.
Makefile.inc1 | ||
---|---|---|
627 ↗ | (On Diff #31328) | This XXX comment can probably go now. |