Page MenuHomeFreeBSD

x11/nvidia-driver: add note about disabling GSP firmware to pkg-message
ClosedPublic

Authored by ashafer on Wed, Apr 2, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 5:51 PM
Unknown Object (File)
Wed, Apr 16, 3:09 PM
Unknown Object (File)
Mon, Apr 14, 7:12 AM
Unknown Object (File)
Sun, Apr 13, 9:24 PM
Unknown Object (File)
Sun, Apr 13, 4:04 PM
Unknown Object (File)
Sat, Apr 12, 8:00 PM
Unknown Object (File)
Sat, Apr 12, 3:56 AM
Unknown Object (File)
Thu, Apr 10, 9:01 AM

Details

Summary

This adds a note about disabling GSP firmware to the pkg-message to
document a recently discovered issues causing suspend/resume to fail.
When a proper fix lands in a future 570 version this can be removed.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashafer created this revision.

Thank you for doing this sir. Probably should have a Fixes: <commithash> in the commit message trailer just in case it slips somehow.

This revision is now accepted and ready to land.Wed, Apr 2, 7:33 PM

You want a Fixes tag in this commit? Or are you saying in the future commit that removes this? I don't think putting a Fixes tag in this commit makes sense, this commit doesn't contain a fix it only documents a workaround.

I was saying possibly this doc commit should have a fixes tag for the commit which makes it necessary. Whenever I need to update the doc due to a previous change, I use that tag so the commits stay together in case something goes wrong somewhere.

I don't think Fixes is a good fit for that but I did include the commit hash of the 570 bump to document the previous change.

x11/nvidia-driver: add note about disabling GSP firmware to pkg-message

This adds a note about disabling GSP firmware to the pkg-message to
document a recently discovered issues causing suspend/resume to fail.
When a proper fix lands in a future 570 version this can be removed.

suspend/resume issues began at commit 0de17c4dce28

Differential Revision:  https://reviews.freebsd.org/D49640

edit: sorry forgot phab does not include the commit message itself, included here.

This revision now requires review to proceed.Wed, Apr 2, 8:08 PM

Sadly, git arc does not update commit messages, but approving again anyway.

This revision is now accepted and ready to land.Wed, Apr 2, 8:09 PM

This would be worth mentioned in Chapter 5 and Chapter 6 of the Handbook, too, for whom bitten but doesn't notice pkg-messages displayed on install/upgrade.

Forgot to mention in my previous post.
Wouldn't PORTREVISION bump needed for this update to be included in official pkg?

Thanks, good catch on the revision. Bumped it now.

This revision now requires review to proceed.Thu, Apr 3, 1:36 PM
This revision is now accepted and ready to land.Thu, Apr 3, 6:50 PM