[NEW-PORT] sysutils/data-prepper: Opensearch Data Prepper

[kiwi]

Summary

systils/data-prepper: Opensearch Data Prepper

Data Prepper is a server-side data collector
capable of filtering, enriching, transforming, normalizing,
and aggregating data for downstream analysis and visualization.

Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor, implicit)
Co-authored-by: kiwi

Test Plan

• Tested with poudriere on 14.2
• Pet portclippy and portlint (except USE_JAVA -> USES+= java)
• Basic install on a jail

[0mp]

Thanks for taking care of this patch.

I posted some comments with suggestions.

Note regarding the location of files: the port installs pretty much everything into its DATADIR. The FreeBSD convention is that we should sort and install files into proper directories, e.g., DATADIR, EXAMPLESDIR, ETCDIR, etc. What comes to my mind is that %%DATADIR%%/pipelines should probably live in ETCDIR and %%DATADIR%%/examples in EXAMPLESDIR. Sometimes, of course, the port is not easy to modify to follow this convention. I leave it up to your discretion to decide if we should install those files into the proper directories.

sysutils/data-prepper/Makefile

9

COMMENT should not be just the name of the program. See https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-comment

23

Is it necessary to set DATADIR here? Isn't the default OK?

35

Seems like a leftover debug command.

48

Please use ${RLN} instead of ${INSTALL} -lrs (defined in Mk/bsd.commands.mk).

sysutils/data-prepper/files/data-prepper.in

29

This should be %%SEARCHUSER%%

30

This should be %%SEARCHGROUP%%

33

%%JAVA_HOME%% is probably better to avoid problems in the future.

sysutils/data-prepper/pkg-messsage

4

Please use %%PREFIX%% here. You'll need to switch to pkg-message.in. See math/scalapack for example.