Page MenuHomeFreeBSD
Differential D47376

Make phabricator access work with php 8.4.0RC3.
ClosedPublic
Actions

Authored by grembo on Oct 31 2024, 10:59 PM.
Tags
None
Referenced Files
F109679873: D47376.id.diff
Sat, Feb 8, 6:51 AM
F109679805: D47376.id145812.diff
Sat, Feb 8, 6:49 AM
F109679768: D47376.id146276.diff
Sat, Feb 8, 6:49 AM
F109662536: D47376.id146282.diff
Sat, Feb 8, 2:19 AM
F109658221: D47376.id145812.diff
Sat, Feb 8, 1:08 AM
Unknown Object (File)
Sun, Feb 2, 3:10 PM
Unknown Object (File)
Sat, Feb 1, 1:15 AM
Unknown Object (File)
Sun, Jan 12, 1:39 PM
View All 15 Files
Subscribers
None

Details

Reviewers
cracauer
grembo
Commits
R11:798fa7e21115: devel/arcanist-lib: Fix for PHP 8.4.0RC3 (revisited)
R11:baae1af5e904: devel/arcanist-lib: Fix for PHP 8.4.0RC3
Summary

Sponsored-By: Klara, Inc.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cracauer requested review of this revision.Oct 31 2024, 10:59 PM
cracauer created this revision.
Harbormaster completed remote builds in B60314: Diff 145812.Oct 31 2024, 11:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2024, 5:03 PM
Closed by commit R11:baae1af5e904: devel/arcanist-lib: Fix for PHP 8.4.0RC3 (authored by grembo). · Explain Why
This revision was automatically updated to reflect the committed changes.
grembo added a commit: R11:baae1af5e904: devel/arcanist-lib: Fix for PHP 8.4.0RC3.
grembo added a comment.Nov 11 2024, 5:03 PM

@cracauer Thank you

grembo added a commit: R11:798fa7e21115: devel/arcanist-lib: Fix for PHP 8.4.0RC3 (revisited).Nov 11 2024, 5:06 PM
grembo added a comment.Nov 11 2024, 5:08 PM

Interesting, what I committed basically overwrote your correct patch (but only once). The port was fixed eventually.

grembo reopened this revision.Nov 11 2024, 5:10 PM
grembo commandeered this revision.
grembo updated this revision to Diff 146282.
grembo edited reviewers, added: cracauer; removed: grembo.

Attempting to fix the differential so it looks not as weird as it does. Sorry #facepalm

grembo accepted this revision.Nov 11 2024, 5:11 PM
This revision is now accepted and ready to land.Nov 11 2024, 5:11 PM
grembo closed this revision.Nov 11 2024, 5:11 PM

Revision Contents
Changeset List

PathSize
devel/
arcanist-lib/
2 lines
files/
11 lines

Diff 146282

View Options

devel/arcanist-lib/Makefile

Loading...
View Options

devel/arcanist-lib/files/patch-src_future_FutureProxy.php

Loading...