Page MenuHomeFreeBSD

devel/cirrus-cli: Add rc.d support
ClosedPublic

Authored by dbaio on Oct 9 2023, 8:55 PM.
Tags
None
Referenced Files
F109285185: D42140.id128474.diff
Mon, Feb 3, 1:36 AM
Unknown Object (File)
Tue, Jan 28, 11:38 PM
Unknown Object (File)
Tue, Jan 28, 11:37 PM
Unknown Object (File)
Tue, Jan 28, 11:37 PM
Unknown Object (File)
Tue, Jan 28, 11:36 PM
Unknown Object (File)
Tue, Jan 28, 11:18 PM
Unknown Object (File)
Fri, Jan 24, 1:44 AM
Unknown Object (File)
Sat, Jan 18, 4:21 AM
Subscribers
None

Details

Test Plan

All tested and running in my env.
Poudriere builds: 12-15 i386-amd64.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dbaio requested review of this revision.Oct 9 2023, 8:55 PM
dbaio created this revision.

Requesting some changes and to recheck added backslashes.

devel/cirrus-cli/Makefile
31

Are you sure this built properly? :P
The backslash might generate errors.

33–38

I will prefer installing it directly to ETC something like:

PLIST_FILES="@sample etc/cirus-worker.yml.sample"

post-install:
        ${INSTALL_DATA} ${FILESDIR}/cirrus-worker.yml ${STAGEDIR}${DOCSDIR}/cirrus-worker.yml.sample

And removing pkg-message.

devel/cirrus-cli/Makefile
31

yep, pretty sure, give it a try, and will see.
anyway, thanks for catching this

33–38

so it would be better to create a pkg-plist and handle the permissions properly.
and also need to adjust the pkg-message after this change.

Yeah feel free to make the changes and commit. Good night. :)

I let the package-message, IMHO it will be useful to the user, but it's up to you.
And thanks for reviewing.

This revision is now accepted and ready to land.Oct 10 2023, 4:22 PM
This revision was automatically updated to reflect the committed changes.