audio/mumble: update to 1.5.517

[vvd]

Summary

Tested on live system 13.2-p1 amd64: build and run. Connect to server 1.4.287 and 1.5.517.
Tested build in poudriere on 13.2-p1 amd64 and i386 with default options and with all options on.

On both amd64 and i386 it build lib/libmumbleoverlay.x86_64.so and lib/libmumbleoverlay.x86.so.
Can't test on arm, ppc and other platforms. Who can test?

Also need testing on 14 with OpenSSL 3 and LLVM 16.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261395

[arrowd]

audio/mumble/Makefile

12–15

If the port uses header-only Boost libraries, I'd rather put the ${LOCALBASE}/include/boost/.../somelib.h in there.

27

I don't think it makes sense to list all Poco libraries here. Unless poco port has options and you want to safeguard the user in the case when he built Poco with, say, JSON disabled.

45

It feels strange that you have nlohmann/json.hpp in both BUILD_DEPENDS and GH_TUPLE. You should probably remove it from the latter.

107–125

Why use our own install target?

[vvd]

audio/mumble/Makefile

12–15

I don't know what includes port really use. Just added boost as dependancy.
I can replace this, but I don't understand why it's better and need to search what exact include it use.

27

I listed all libs linked with port.
At least JSON, XML and ZIP are options for devel/poco.
Maybe we can remove Foundation and Utils - I don't know. Need advice from poco-guru.

45

Build stage use submodules for build "license" anly - already tested - fails without this line.
But other build stages uses port devel/nlohmann-json.

107–125

I don't know - I'm not teh author of the port. I just update it with minimal changes.

[arrowd]

audio/mumble/Makefile

12–15

This is simply more explicit. Just do grep -r boost/ ${WRKSRC} to get a list of headers and choose more or less representative one.

27

I'm 99% sure there is no poco-guru. Remove non-option library dependencies then.

45

Doesn't that help? https://github.com/mumble-voip/mumble/blob/c338d1df3b89d8fc41b822950f37524084d65833/src/mumble/CMakeLists.txt#L28

[vvd]

audio/mumble/Makefile

12–15

boost/accumulators/accumulators.hpp
boost/accumulators/statistics/extended_p_square.hpp
boost/accumulators/statistics/mean.hpp
boost/accumulators/statistics/stats.hpp
boost/accumulators/statistics/variance.hpp
boost/array.hpp
boost/bind.hpp
boost/bind/bind.hpp
boost/chrono.hpp
boost/function.hpp
boost/make_shared.hpp
boost/optional.hpp
boost/scoped_ptr.hpp
boost/shared_array.hpp
boost/shared_ptr.hpp
boost/signals.hpp
boost/thread/once.hpp
boost/type_traits/is_detected.hpp
boost/typeof/typeof.hpp
boost/version.hpp

What is the best choice?

27

ok

45

Check above:

CMAKE_OFF=	bundled-json

Weird - I tested and was error during license build without this line in GH_TUPLE.
But now build fine without it.

[arrowd]

audio/mumble/Makefile

12–15

I'd go with boost/version.hpp.

[vvd]

Fixed text-to-speech options.

[arrowd]

Great job!