Page MenuHomeFreeBSD

devel/py-setuptools_scm: update to 8.0.4
AbandonedPublic

Authored by vishwin on Mar 27 2023, 12:16 PM.
Tags
None
Referenced Files
F102685054: D39288.id135198.diff
Fri, Nov 15, 8:33 PM
F102668788: D39288.id128976.largetrue.diff
Fri, Nov 15, 3:00 PM
F102668778: D39288.id128976.largetrue.diff
Fri, Nov 15, 2:59 PM
Unknown Object (File)
Fri, Nov 15, 6:42 AM
Unknown Object (File)
Fri, Nov 15, 3:06 AM
Unknown Object (File)
Wed, Nov 13, 6:37 PM
Unknown Object (File)
Tue, Nov 12, 9:06 AM
Unknown Object (File)
Sun, Nov 10, 10:42 AM

Details

Summary

Switch to USE_PYTHON= pep517 pytest

Add devel/py-wheel as a BUILD_DEPENDS -- not mentioned in upstream
pyproject.toml, but clearly needed for building.

Add security/gnupg, devel/git and devel/mercurial to TEST_DEPENDS
since so many tests require them. Do not add (eg.) sysutils/coreutils
for dir or ressurect the expired devel/py-hg-git for particular
tests.

Delete all patch files as these are no longer necessary

ChangeLog: https://github.com/pypa/setuptools_scm/blob/v7.1.0/CHANGELOG.rst

Test Plan

make test

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 56340
Build 53228: arc lint + arc unit

Event Timeline

matthew added a reviewer: Python.

Can we update devel/py-setuptools_scm please? This builds correctly in poudriere, and make test passes.

This needs to wait until after D39095 and D39303 land. setuptools does not have wheel functionality of its own, so it will depend on wheel after the former lands.

devel/py-setuptools_scm/Makefile
15
20

Even though technically needed, cannot have this here due to downstream environment pollution. Consumers will explicitly specify setuptools in addition to this.

devel/py-setuptools_scm: avoid environment pollution

Ports will specify their own requirements on setuptools versions,
which (although technically a requirement from upstream for _this_
package) we shouln't override here.

devel/py-setuptools_scm: Ensure tests use python modules from ${STAGEDIR}

This allows make test to work when building a newer version of the
package on a system where an older version is already installed.

vishwin added a reviewer: matthew.

updating this to 8.0.4

vishwin retitled this revision from devel/py-setuptools_scm: update to 7.1.0 to devel/py-setuptools_scm: update to 8.0.4.Oct 12 2023, 4:44 AM
  • update to 8.0.4

round one of probably many, directory name to change

  • devel/py-setuptools_scm: move directory to match updated package name
  • devel/py-setuptools-scm: switch consumers

Updating the port, renaming the port and updating all of the dependencies makes this very hard to review. Would have been easier separated into two bits. Just the port update in one, and all the bits connected to renaming the port in the other.

Anyhow:

Port update bits in https://reviews.freebsd.org/differential/diff/128646/ -- looks good to me.

Renaming related stuff: I can't see any obvious errors, seems fine.

Since all of the consumers of devel/py-setuptools_scm7 have been switched to the updated devel/py-setuptools-scm there's no point keeping devel/py-setuptools_scm7. Happy for that to be deleted.

  • devel/py-setuptools-scm: add BUILD_DEPENDS=${PY_SETUPTOOLS} to consumers
  • devel/py-{flit-scm,hatch-vcs}: add RUN_DEPENDS=${PY_SETUPTOOLS}

Yeah it's unfortunate that this review ballooned significantly, but the package name change, however subtle, forced the hand. Hacking ${DISTNAME} or only adjusting ${PORTNAME} weren't going to do. As a side effect, this takes some load off D39303.

An exp-run will be requested.

  • devel/py-setuptools-scm: "temporarily" add devel/py-wheel
  • benchmarks/py-asv: fix devel/py-setuptools-scm

rebase after devel/py-pytoolconfig update

  • devel/py-ddtrace: setuptools-scm max version not set upstream, remove
  • science/py-emmet-core: remove setuptools-scm version restrictions
  • devel/py-setuptools-scm: flip two more consumers

fix typo in science/py-emmet-core

rebase after committing some missing ${PY_SETUPTOOLS} cases

at least deskutils/py-khard build failure not obviously setuptools-related

rebase, add math/py-matplotlib

  • rebase
  • update devel/Makefile
  • science/py-emmet-core: switch to devel/py-setuptools_scm7 (instead of patching setup.py)