Page MenuHomeFreeBSD

arm64: don't loop forever if first option in kern.cfg.order not available
ClosedPublic

Authored by imp on Sep 23 2022, 8:54 PM.
Tags
None
Referenced Files
F97459342: D36682.diff
Sun, Sep 29, 12:21 PM
F97317069: D36682.diff
Sat, Sep 28, 3:25 PM
Unknown Object (File)
Thu, Sep 26, 3:37 PM
Unknown Object (File)
Mon, Sep 23, 7:51 AM
Unknown Object (File)
Sat, Sep 21, 10:39 PM
Unknown Object (File)
Fri, Sep 20, 12:27 AM
Unknown Object (File)
Thu, Sep 19, 3:26 PM
Unknown Object (File)
Thu, Sep 5, 6:13 AM
Subscribers

Details

Summary

strchr returns a pointer to the ',', so if the first option in the list
isn't available, we need to step over the , to look at the next
option. So if kern.cfg.order="acpi,fdt" and we have no acpi, we'd loop
forever with order=',fdt'.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 23 2022, 8:54 PM
This revision is now accepted and ready to land.Sep 23 2022, 8:58 PM
jhb added a subscriber: jhb.

typo in the title: s/forver/forever/

Not sure if you want to quote the comma in the second line, or maybe just spell it out (e.g. "we need to step over the comma")

imp retitled this revision from arm64: don't loop forver if first option in kern.cfg.order not available to arm64: don't loop forever if first option in kern.cfg.order not available.Sep 23 2022, 9:03 PM
In D36682#832825, @jhb wrote:

Not sure if you want to quote the comma in the second line, or maybe just spell it out (e.g. "we need to step over the comma")

Will add before push. Thanks!

Ah yes I remember this issue