FreeBSD Handbook: FreeBSD Boot Process: GNU GRUB
ClosedPublic
Actions

Authored by grahamperrin on Sep 23 2022, 6:31 PM.

Details

Reviewers

carlavilla
gjb

Group Reviewers

docs

Commits

Summary

https://docs.freebsd.org/en/books/handbook/boot/#boot-introduction mentions GRUB. Some readers will wonder why things such as installers for FreeBSD are not suitably GRUB-aware; and why there's so little FreeBSD-provided documentation about GRUB.

Add a note, directing users of GRUB to GNU-provided documentation.

Case correction: GRUB should be uppercase.

Elsewhere in the page: a minor correction, superfluous space before a colon.

Test Plan

Preceding this review:

Repository

R9 FreeBSD doc repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

grahamperrin requested review of this revision.Sep 23 2022, 6:31 PM

grahamperrin created this revision.

A few minor comments. The rest looks good.

documentation/content/en/books/handbook/boot/_index.adoc
110	Contractions like there's are discouraged in the handbook -> there is
111	The please is superfluous and may be interpreted as a command.

Approved, once @bcr's comments are addressed.

This revision is now accepted and ready to land.Sep 23 2022, 7:01 PM

This revision was automatically updated to reflect the committed changes.

Trailing whitespace error not visible in Phabricator.

documentation/content/en/books/handbook/boot/_index.adoc
111	Trailing whitespace error – not visible in Phabricator – caught with a first run of git-apply(1). It'll be impossible for me to break the decades-long habit of intentionally adding white space, I'll sometimes forget to remove what's required for diff purposes. Sorry. Fixed prior to push, notes to self at https://github.com/freebsd/freebsd-doc/pull/87#issuecomment-1256883300.